Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: prevent loading state with QR code & version to 5.0.11 #2634

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Jul 31, 2024

What's Changed

Full Changelog: 5.0.10...5.0.11

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 31, 2024 2:17pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 31, 2024 2:17pm

@svenvoskamp svenvoskamp changed the title hotfix: prevent loading state with QR code hotfix: prevent loading state with QR code & version to 5.0.11 Jul 31, 2024
Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way to add a test for this right?

@svenvoskamp
Copy link
Contributor Author

No way to add a test for this right?

It requires a mobile app, so don't think this testable

@svenvoskamp svenvoskamp merged commit 81585ad into V5 Jul 31, 2024
12 checks passed
@svenvoskamp svenvoskamp deleted the fix/farcaster-loading-state branch July 31, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants